zhangyu-duck commented on code in PR #21504: URL: https://github.com/apache/nuttx/pull/21504#discussion_r4510519739
########## arch/tricore/src/common/tricore_irq.c: ########## @@ -36,9 +36,14 @@ #include "tricore_internal.h" -#include "IfxSrc.h" -#include "IfxCpu.h" -#include "IfxInt_reg.h" +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* Service request control register of an IRQ */ + +#define TRICORE_SRC(irq) \ Review Comment: what i mean is TRICORE_SRC2IRQ in irq.h, but why you define TRICORE_SRC in irq.c, repeat place ,you shoult name TRICORE_IRQ2SRC and define in irq.h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
