anatol commented on code in PR #21646:
URL: https://github.com/apache/nuttx/pull/21646#discussion_r4532532064


##########
crypto/rijndael.c:
##########
@@ -1075,9 +1075,9 @@ void rijndaelencrypt(FAR const uint32_t *rk, int nr,
   PUTU32(ct + 12, s3);
 }
 
-static void rijndaeldecrypt(FAR const uint32_t *rk,
-                            int nr, FAR const uint8_t *ct,
-                            FAR uint8_t *pt)
+static void __attribute__((no_sanitize("shift")))

Review Comment:
   It is security area and I preferred to change the attribute to minimize the 
change surface. But I do not mind changing the C code itself - it would be a 
cast in the expression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to