ThePassionate commented on PR #21646:
URL: https://github.com/apache/nuttx/pull/21646#issuecomment-6785267675

   Hi @anatol , this exact UB is already fixed in [#21589 (commit 
1d7db513)](https://github.com/apache/nuttx/pull/21589) by casting the TD4[...] 
lookups to uint32_t before the shift — the alternative you mentioned in the 
description:
   
   
   s0 = ((uint32_t)TD4[(t0 >> 24)] << 24) ^ ...
   The cast removes the UB itself rather than excluding the function from the 
sanitizer, and it has been running in our production tree. Maybe we can just 
use this fix instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to