acassis commented on PR #21646:
URL: https://github.com/apache/nuttx/pull/21646#issuecomment-6794976986

   > > > The `check` step generates an incorrect errors
   > > > ```
   > > > Error: /home/runner/work/nuttx/nuttx/nuttx/crypto/rijndael.c:731:14: 
error: Bad alignment
   > > > Error: /home/runner/work/nuttx/nuttx/nuttx/crypto/rijndael.c:1014:12: 
error: Bad alignment
   > > > Error: /home/runner/work/nuttx/nuttx/nuttx/crypto/rijndael.c:1098:4: 
error: Bad alignment
   > > > Error: /home/runner/work/nuttx/nuttx/nuttx/crypto/rijndael.c:1099:4: 
error: Bad alignment
   > > > Error: /home/runner/work/nuttx/nuttx/nuttx/crypto/rijndael.c:1100:4: 
error: Bad alignment
   > > > Error: /home/runner/work/nuttx/nuttx/nuttx/crypto/rijndael.c:1101:4: 
error: Bad alignment
   > > > ```
   > > > 
   > > > 
   > > >     
   > > >       
   > > >     
   > > > 
   > > >       
   > > >     
   > > > 
   > > >     
   > > >   
   > > > there are unrelated lines that i did not touch.
   > > > To avoid failures like this one the repo formatting need to be fixed, 
see [#21399](https://github.com/apache/nuttx/issues/21399)
   > > 
   > > 
   > > [@anatol](https://github.com/anatol) when you modify a file the CI 
checks the entire file. Please fix these alignment, this way the CI will pass 
and any other people modifying this file in the future will not see this issue.
   > 
   > Mixing code changes with unrelated cleanup is a poor idea. The cleanup 
should be done once and across the repo. And forget about this issue forever.
   
   @anatol I totally agree, in fact it was done initially when the code moved 
to GitHub. The issue is someone read again the Coding Style and discover that 
some item is missing, then he/she adds it to nxstyle.c, so old files that used 
to pass now will fail. But it only fails when someone modify it, because the CI 
check the complete file, not only the changed lines


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to