YuuichiNakamura commented on a change in pull request #1377: URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r493668548
########## File path: drivers/note/noteram_driver.c ########## @@ -57,28 +58,33 @@ struct noteram_info_s { volatile unsigned int ni_head; volatile unsigned int ni_tail; + volatile unsigned int ni_read; Review comment: Same as https://github.com/apache/incubator-nuttx/pull/1377#discussion_r493667049 I have wanted to introduce non-destructive read to /dev/note. It is useful for example no overwrite mode in on-boot instrumentation. After boot, the instrumentation data while boot is kept in the circular buffer and never lost until new instrumentation is started even when we read the data. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org