YuuichiNakamura commented on a change in pull request #1377:
URL: https://github.com/apache/incubator-nuttx/pull/1377#discussion_r498665909



##########
File path: sched/Kconfig
##########
@@ -1000,6 +1000,26 @@ config SCHED_INSTRUMENTATION_FILTER
                The filter logic can be configured by sched_note_filter APIs 
defined in
                include/nuttx/sched_note.h.
 
+config SCHED_INSTRUMENTATION_FILTER_ENABLE_ONBOOT

Review comment:
       Because the filter mode contains the following variables:
   
   1.  global instrumentation enable/disable
   2.  syscall/irq instrumentation enable flag
   
   SCHED_INSTRUMENTATION_FILTER_ENABLE_ONBOOT defines the default value of 1.
   SCHED_INSTRUMENTATION_FILTER_ENABLE_ONBOOT_MODE defines 2. (The name may be 
confusing.)
   
   @xiaoxiang781216 Do you mean that these two variables should be integrated 
to one mode variable and provide only one configuration which defines the 
default value of the mode variable?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to