zhangyu-duck commented on PR #21546: URL: https://github.com/apache/nuttx/pull/21546#issuecomment-6967090095
There are three main issues. Once these are addressed, you can go ahead and merge the changes; I will handle any further adjustments later. 1. The linker script includes a user script for "protect mode"—doesn't that need to be modified? 2. The BIST (Built-In Self-Test) in the startup code appears to be written in C; since it functions as a driver, it shouldn't be placed inside `head.asm`. 3. It seems unnecessary to have both `main` and `start`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
