zhangyu-duck commented on PR #21546: URL: https://github.com/apache/nuttx/pull/21546#issuecomment-6971031991
> > I will handle any further adjustments later. > > Review is to address the changes needed, doesn't make sense to merge now and rework again e.g #21951 > > > The linker script includes a user script for "protect mode"—doesn't that need to be modified? > > Never tested or enabled user mode, I will check > > > The BIST (Built-In Self-Test) in the startup code appears to be written in C; since it functions as a driver, it shouldn't be placed inside head.asm. > > It is one time initialization sequence and calling C functions needs CSAs and a stack, and the DSPR can't be cleared once the CSAs live there or again setting CSA list is redundant. > > > It seems unnecessary to have both main and start. can we merge them? > > yes which one to stay main or start? Please refer to the implementation by illd; it also included MBIST for the DSPR. Also, since this is a driver, I strongly recommend using the C programming language. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
