ssekar15 commented on code in PR #21546: URL: https://github.com/apache/nuttx/pull/21546#discussion_r4609140598
########## arch/tricore/src/common/tricore_internal.h: ########## @@ -155,17 +155,15 @@ struct tricore_trap_s * end of the heap is CONFIG_RAM_END */ -extern uintptr_t __USTACK0_END[]; -extern uintptr_t __USTACK0[]; -#define g_idle_topstack __USTACK0 Review Comment: changed for valid "consistent name" as per your earlier comments. As similar to single trap vector naming why do we need percpu name? ########## boards/tricore/tc3xx/a2g-tc397-5v-tft/scripts/tricore.lsl: ########## @@ -0,0 +1,190 @@ +/**************************************************************************** + * boards/tricore/tc3xx/a2g-tc397-5v-tft/scripts/tricore.lsl + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#include <nuttx/config.h> + +#include "tc1v1_6_2.lsl" Review Comment: TASKING ships it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
