zhangyu-duck commented on PR #21546: URL: https://github.com/apache/nuttx/pull/21546#issuecomment-6971682892
> > > > @ssekar15 could you split the unrelated change to separated pr? some patches need more discuss to pass the review which will block other simple patch get merged. > > > > > > > > > Sorry I don't understand, initially this PR was small then @zhangyu-duck gave comments and becomes huge to accommodate all. I asked the same 5days before, now again and again rework due to conflict of comments between reviewer is painful [#21546 (comment)](https://github.com/apache/nuttx/pull/21546#issuecomment-6854832512) > > > > > > I don’t understand the logic behind how my comment could cause your PR to grow in size.?? > > I meant the review request leads to added more changes. Lets come to alignment of below to satisfy this PR to be merged. [#21546 (comment)](https://github.com/apache/nuttx/pull/21546#issuecomment-6967090095) > > agree? Let’s tentatively identify a few core points of divergence so that we can move forward: 1. First, I consider `sp`, `btv`, and `biv` to be assembly-level constructs, which are tightly coupled to the underlying architecture. 2. For drivers—such as those for BIST—it is preferable to use C. what about this, my previous comments have adhered to these two points; do have any questions about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
