v01d commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729016848
I went over this again. I'm now (hopefully) addressing both issues correctly. These were actually unrelated: the missing release on receive queue was simply a mistake. As for the release on transmit (which I added to the sim BT device) is now placed inside bt_send(), which I think is the correct place since this is the last point of the upper-half of BT drivers where the buffer will be seen. This is only done when NuttX's stack is disabled, since as I mentioned NuttX's stack needs to keep the buffer around, whereas for an external BT stack, this buffer is hidden inside networking layer so it needs to be released once sent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org