xiaoxiang781216 commented on pull request #4193: URL: https://github.com/apache/incubator-nuttx/pull/4193#issuecomment-884883213
> @xiaoxiang781216 - Did you see my request to do this work on a branch? The type of change could be like the change to the File FS flags, that will have a lot of clean up. It would be better not to trickle this in piecemeal. As I already explain before, this is VFS layer change which isn't related to the individual file system. If one particular file system doesn't support the file size large than 4GB, we shouldn't modify the file system directly to support this feature. Instead, you can ask the file system designer to add the >4GB support. For example, Microsoft never plan to support >4GB on FAT, but develop a new file system for it: https://en.wikipedia.org/wiki/ExFAT So, it expect that both 32bit and 64bit file system coexist on NuttX(Linux too) for ever. Here is a old summary how this feature support on Linux: https://users.suse.com/~aj/linux_lfs.html > It should be done and fully tested on real HW before it comes in to master. > Event the printf change will increase code size with FS_LARGEFILE off. Why? I don't see any reason that the code size if FS_LARGEFILE off. Could you explain more? > So lets get the real impact of this change on code size and make it really work 1005 on all the FS, before it come in to master. FS should work as before with FS_LARGEFILE==y when the file size is smaller than 4GB from theory, but we need test anyway. So, this patch is completed from the VFS layer and all file system should work as before when file size is smaller than 4GB. The next action is reviewing each individual file system and implement the large file support if it support natively. I don't commit to do this work for all file system supported by NuttX. My interesting is littlefs, hostfs, userfs and maybe nfs. But, anyway this patch doesn't make the situation worse, why not merge to mainline and let user try and feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
