davids5 commented on pull request #4193: URL: https://github.com/apache/incubator-nuttx/pull/4193#issuecomment-884921443
>>It should be done and fully tested on real HW before it comes in to master. Event the printf change will increase code size with FS_LARGEFILE off. >Why? I don't see any reason that the code size if FS_LARGEFILE off. Could you explain more? The effect can be seen in this [PR](https://github.com/apache/incubator-nuttx-apps/pull/811/files ) it cost 8 bytes (yes it is a debug path, but it still need to fit when needed)  1953165 - 1953157 = 8 This is about code space and useless bloat. If it is Off it need to cost 0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
