patacongo commented on a change in pull request #4193:
URL: https://github.com/apache/incubator-nuttx/pull/4193#discussion_r675263956
##########
File path: include/nuttx/fs/hostfs.h
##########
@@ -106,8 +106,13 @@ typedef int16_t nuttx_uid_t;
typedef uint16_t nuttx_dev_t;
typedef uint16_t nuttx_ino_t;
typedef uint16_t nuttx_nlink_t;
+#ifdef CONFIG_FS_LARGEFILE
+typedef int64_t nuttx_off_t;
Review comment:
Requires CONFIG_LONG_LONG. This will break all ZiLOG platforms since
the ZiLOG compiler does not support int64_t types. Similarly for other
references to CONFIG_FS_LARGEFILE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
