gustavonihei commented on a change in pull request #4270:
URL: https://github.com/apache/incubator-nuttx/pull/4270#discussion_r682620284
##########
File path: libs/libc/time/lib_localtime.c
##########
@@ -2528,9 +2537,20 @@ void tzset(void)
{
FAR const char *name;
- tz_semtake(&g_lcl_sem);
-
name = getenv("TZ");
+ if (g_lcl_isset > 0 && name && strcmp(g_lcl_tzname, name) == 0)
+ {
+ return;
+ }
+
+#ifndef __KERNEL__
+ if (up_interrupt_context())
+ {
+ return;
+ }
Review comment:
The point here is responsibility, which I think is important for having
a well-defined interface.
Maybe we should add to time-related APIs that they should not be called from
interrupt context.
Don't you think that, although an easier change, checking `if
(up_interrupt_context())` here seems more like a quick fix?
For me it makes more sense to explicitly state the usage restriction on the
APIs and fix the API users accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
