gustavonihei commented on a change in pull request #4270:
URL: https://github.com/apache/incubator-nuttx/pull/4270#discussion_r682648787
##########
File path: libs/libc/time/lib_localtime.c
##########
@@ -2528,9 +2537,20 @@ void tzset(void)
{
FAR const char *name;
- tz_semtake(&g_lcl_sem);
-
name = getenv("TZ");
+ if (g_lcl_isset > 0 && name && strcmp(g_lcl_tzname, name) == 0)
+ {
+ return;
+ }
+
+#ifndef __KERNEL__
+ if (up_interrupt_context())
+ {
+ return;
+ }
Review comment:
> If we allow kernel component call locale time related API, the check
need be done here instead each call site.
I think I got your point. This restriction does not apply to drivers since
this change only targets the non-kernel build.
Indeed, it would be a bit hard to check in each call site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
