gustavonihei commented on a change in pull request #4270:
URL: https://github.com/apache/incubator-nuttx/pull/4270#discussion_r682623574
##########
File path: libs/libc/time/lib_localtime.c
##########
@@ -2528,9 +2537,20 @@ void tzset(void)
{
FAR const char *name;
- tz_semtake(&g_lcl_sem);
-
name = getenv("TZ");
+ if (g_lcl_isset > 0 && name && strcmp(g_lcl_tzname, name) == 0)
+ {
+ return;
+ }
+
+#ifndef __KERNEL__
+ if (up_interrupt_context())
+ {
+ return;
+ }
Review comment:
Not being able to be called from interrupt context is a real limitation
for time-related APIs.
There are similar examples throughout NuttX code where assumption and
limitations are documented on function APIs:
https://github.com/apache/incubator-nuttx/blob/master/net/arp/arp.h#L253-L255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
