no1wudi commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780673385



##########
File path: arch/risc-v/include/common/irq.h
##########
@@ -134,6 +140,14 @@
 #  error not supported !!!
 #endif
 
+/* REG size */
+
+#ifdef CONFIG_ARCH_RV32
+#define REG_SIZE            1
+#else
+#define REG_SIZE            2
+#endif

Review comment:
       Removed, REG_SIZE is unused

##########
File path: arch/risc-v/src/common/riscv_internal.h
##########
@@ -171,8 +160,8 @@ void riscv_ack_irq(int irq);
 void riscv_copystate(uint64_t *dest, uint64_t *src);
 void riscv_copyfullstate(uint64_t *dest, uint64_t *src);
 #else
-void riscv_copystate(uint32_t *dest, uint32_t *src);
-void riscv_copyfullstate(uint32_t *dest, uint32_t *src);
+void riscv_copystate(uintptr_t *dest, uintptr_t *src);
+void riscv_copyfullstate(uintptr_t *dest, uintptr_t *src);
 #endif

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to