pkarashchenko commented on a change in pull request #5204:
URL: https://github.com/apache/incubator-nuttx/pull/5204#discussion_r820247867
##########
File path: drivers/input/ajoystick.c
##########
@@ -526,12 +461,7 @@ static ssize_t ajoy_read(FAR struct file *filep, FAR char
*buffer,
/* Get exclusive access to the driver structure */
- ret = ajoy_takesem(&priv->au_exclsem);
- if (ret < 0)
- {
- ierr("ERROR: ajoy_takesem failed: %d\n", ret);
- return ret;
- }
+ flags = enter_critical_section();
Review comment:
No. And that is why I'm keeping this discussion open. `al_buttons`
access only board GPIOs via arch specific calls and do not use pending
primitives (example sama5/giant-board: `ajoy_buttons` calls `sam_pioread`),
while `al_sample` can be implemented as a reader from a file device and can
pend (example sama5/giant-board: `ajoy_sample` calls `file_read` and
`ajoy_buttons` at the end).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
