pkarashchenko commented on a change in pull request #5760:
URL: https://github.com/apache/incubator-nuttx/pull/5760#discussion_r828392899
##########
File path: arch/xtensa/src/esp32s3/esp32s3_serial.c
##########
@@ -1124,7 +1108,7 @@ int up_putc(int ch)
up_lowputc('\r');
}
- up_lowputc(ch);
+ up_lowputc((char)ch);
Review comment:
I do not think that this is needed
##########
File path: arch/xtensa/src/esp32s3/esp32s3_serial.c
##########
@@ -687,7 +675,7 @@ static bool esp32s3_txempty(struct uart_dev_s *dev)
static void esp32s3_send(struct uart_dev_s *dev, int ch)
{
- esp32s3_lowputc_send_byte(dev->priv, ch);
+ esp32s3_lowputc_send_byte(dev->priv, (char)ch);
Review comment:
I do not think that this is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
