gustavonihei commented on a change in pull request #5760:
URL: https://github.com/apache/incubator-nuttx/pull/5760#discussion_r828398043



##########
File path: arch/xtensa/src/esp32s3/esp32s3_serial.c
##########
@@ -1124,7 +1108,7 @@ int up_putc(int ch)
       up_lowputc('\r');
     }
 
-  up_lowputc(ch);
+  up_lowputc((char)ch);

Review comment:
       This is for silencing clang-tidy's *bugprone-narrowing-conversions* 
warning:
   
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines-narrowing-conversions.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to