gustavonihei commented on a change in pull request #5760:
URL: https://github.com/apache/incubator-nuttx/pull/5760#discussion_r828410703
##########
File path: arch/xtensa/src/esp32s3/esp32s3_serial.c
##########
@@ -687,7 +675,7 @@ static bool esp32s3_txempty(struct uart_dev_s *dev)
static void esp32s3_send(struct uart_dev_s *dev, int ch)
{
- esp32s3_lowputc_send_byte(dev->priv, ch);
+ esp32s3_lowputc_send_byte(dev->priv, (char)ch);
Review comment:
No, I am just using clang-tidy as a static code analyzer.
This warning is a minor one, I agree with you that is not actually needed
and will probably have no impact on the generated code.
But even so I think it doesn't hurt to make the conversion explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
