pkarashchenko commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-nuttx/pull/5897#discussion_r836802141



##########
File path: arch/xtensa/src/lx6/Toolchain.defs
##########
@@ -55,8 +59,14 @@ else
   MAXOPTIMIZATION += -fomit-frame-pointer
 endif
 
-ifeq ($(CONFIG_MM_KASAN),y)
-  ARCHCPUFLAGS += -fsanitize=kernel-address
+CXXFLAGS =
+
+ifneq ($(CONFIG_CXX_EXCEPTION),y)
+  CXXFLAGS += -fno-exceptions -fcheck-new

Review comment:
       Why not to reuse `ARCHCXXFLAGS` and leave `CXXFLAGS :=` as is? I mean 
`ARCHCXXFLAGS += -fno-exceptions -fcheck-new`? The same as it is done few lines 
above for `ARCHCPUFLAGS += -fsanitize=kernel-address`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to