gustavonihei commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-nuttx/pull/5897#discussion_r836812661
##########
File path: arch/xtensa/src/lx6/Toolchain.defs
##########
@@ -55,8 +59,14 @@ else
MAXOPTIMIZATION += -fomit-frame-pointer
endif
-ifeq ($(CONFIG_MM_KASAN),y)
- ARCHCPUFLAGS += -fsanitize=kernel-address
+CXXFLAGS =
+
+ifneq ($(CONFIG_CXX_EXCEPTION),y)
+ CXXFLAGS += -fno-exceptions -fcheck-new
Review comment:
It is also an option. At first I preferred to leave `ARCHCFLAGS` and
`ARCHCXXFLAGS` restricted to the `board` definition.
But after your comment, I believe it makes sense for the `Toolchain.defs`
file to define arch-common C and C++ flags, and each board will append
application-specific flags.
I'll submit another patch with this approach.
Thanks for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
