gustavonihei commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-nuttx/pull/5897#discussion_r837450190
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/scripts/Make.defs
##########
@@ -41,8 +41,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0
-ARCHCXXFLAGS = $(ARCHCFLAGS) -fno-exceptions -fcheck-new -fno-rtti
+ARCHCFLAGS += -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0
+ARCHCXXFLAGS += -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0 -std=c++17
Review comment:
But now `ARCHCFLAGS` may contain C-specific flags defined in
`Toolchain.defs` file, therefore we cannot simply expand it here as part of
`ARCHCXXFLAGS`.
This refactor would then require another variable for holding flags common
to both C and C++, which needs to evaluate if it is indeed worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
