gustavonihei commented on code in PR #6162: URL: https://github.com/apache/incubator-nuttx/pull/6162#discussion_r859821671
########## arch/risc-v/src/common/riscv_pmp.c: ########## @@ -600,9 +600,14 @@ int riscv_config_pmp_region(uintptr_t region, uintptr_t attr, # error "XLEN of risc-v not supported" # endif - /* fence is needed when page-based virtual memory is implemented */ +#ifdef CONFIG_ARCH_HAVE_S_MODE Review Comment: I feel that `ARCH_RV_ISA_S` may not be correct, since the RISC-V Spec does not define an **S** ISA extension module. Instead they are described as part of the `Supervisor-level ISA`, so I initially thought that using `CONFIG_ARCH_HAVE_S_MODE` would better reflect the capabilities of a given RISC-V implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
