gustavonihei commented on code in PR #6162:
URL: https://github.com/apache/incubator-nuttx/pull/6162#discussion_r859825192


##########
arch/risc-v/src/common/riscv_pmp.c:
##########
@@ -600,9 +600,14 @@ int riscv_config_pmp_region(uintptr_t region, uintptr_t 
attr,
 #   error "XLEN of risc-v not supported"
 # endif
 
-  /* fence is needed when page-based virtual memory is implemented */
+#ifdef CONFIG_ARCH_HAVE_S_MODE

Review Comment:
   I just noticed that the `CONFIG_ARCH_USE_S_MODE` may be more suitable for 
this purpose.
   What do you think about it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to