[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6665: arch/stack: get correct stack remain and limit dump size when sp is not within stack

[GitBox]

xiaoxiang781216 commented on code in PR #6665:
URL: https://github.com/apache/incubator-nuttx/pull/6665#discussion_r928941254


##########
arch/arm64/src/common/arm64_internal.h:
##########
@@ -352,6 +352,7 @@ void arm64_usbuninitialize(void);
 /* Debug */
 
 #ifdef CONFIG_STACK_COLORATION
+size_t arm64_stackcheck(void *stackbase, size_t nbytes);

Review Comment:
   ditto



##########
arch/arm/src/common/arm_internal.h:
##########
@@ -440,6 +440,7 @@ void arm_usbuninitialize(void);
 
 /* Debug ********************************************************************/
 #ifdef CONFIG_STACK_COLORATION
+size_t arm_stackcheck(void *stackbase, size_t nbytes);

Review Comment:
   arm_stack_check



##########
arch/Kconfig:
##########
@@ -837,6 +837,14 @@ config ARCH_STACKDUMP
        ---help---
                Enable to do stack dumps after assertions
 
+if ARCH_STACKDUMP
+
+config ARCH_STACKDUMP_LIMIT_LENGTH

Review Comment:
   LIMIT_LENGTH->MAX_LENGTH



##########
arch/arm/src/common/arm_assert.c:
##########
@@ -353,9 +354,12 @@ static void arm_dump_stack(const char *tag, uint32_t sp,
     {
       _alert("ERROR: %s Stack pointer is not within the stack\n", tag);
 
+      remain = size - arm_stackcheck((FAR void *)(uintptr_t)base, size);

Review Comment:
   need:
   ```
   #ifdef CONFIG_STACK_COLORATION
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org