Donny9 commented on code in PR #6665:
URL: https://github.com/apache/incubator-nuttx/pull/6665#discussion_r930570574
##########
arch/arm/src/common/arm_assert.c:
##########
@@ -352,10 +352,17 @@ static void arm_dump_stack(const char *tag, uint32_t sp,
else
{
_alert("ERROR: %s Stack pointer is not within the stack\n", tag);
+#ifdef CONFIG_STACK_COLORATION
Review Comment:
Done!
##########
arch/risc-v/src/common/riscv_assert.c:
##########
@@ -307,6 +307,35 @@ static inline void riscv_showtasks(void)
#endif
}
+/****************************************************************************
+ * Name: riscv_dump_stack
+ ****************************************************************************/
+
+static void riscv_dump_stack(const char *tag, uintptr_t sp,
+ uintptr_t base, uint32_t size, bool force)
+{
+ uintptr_t top = base + size;
+
+ _alert("%s Stack:\n", tag);
+ _alert("sp: %08" PRIx32 "\n", sp);
+ _alert(" base: %08" PRIx32 "\n", base);
Review Comment:
Done!
##########
arch/risc-v/src/common/riscv_assert.c:
##########
@@ -307,6 +307,35 @@ static inline void riscv_showtasks(void)
#endif
}
+/****************************************************************************
+ * Name: riscv_dump_stack
+ ****************************************************************************/
+
+static void riscv_dump_stack(const char *tag, uintptr_t sp,
+ uintptr_t base, uint32_t size, bool force)
+{
+ uintptr_t top = base + size;
+
+ _alert("%s Stack:\n", tag);
+ _alert("sp: %08" PRIx32 "\n", sp);
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
