Donny9 commented on code in PR #6665:
URL: https://github.com/apache/incubator-nuttx/pull/6665#discussion_r930570504
##########
arch/Kconfig:
##########
@@ -837,6 +837,14 @@ config ARCH_STACKDUMP
---help---
Enable to do stack dumps after assertions
+if ARCH_STACKDUMP
+
+config ARCH_STACKDUMP_MAX_LENGTH
+ int "The maximum length for dump stack on assertions"
Review Comment:
Done.
##########
arch/xtensa/src/common/xtensa_dumpstate.c:
##########
@@ -395,6 +395,15 @@ void xtensa_dumpstate(void)
}
else
{
+#ifdef CONFIG_STACK_COLORATION
+ uint32_t remain;
+
+ remain = ustacksize - xtensa_stack_check((uintptr_t)ustackbase,
+ ustacksize);
+ ustackbase += remain;
+ ustacksize -= remain;
+#endif
+
_alert("ERROR: Stack pointer is not within allocated stack\n");
xtensa_stackdump(ustackbase, ustackbase + ustacksize);
Review Comment:
Done
##########
arch/risc-v/src/common/riscv_assert.c:
##########
@@ -327,11 +327,19 @@ static void riscv_dump_stack(const char *tag, uintptr_t
sp,
}
else
{
+#ifdef CONFIG_STACK_COLORATION
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
