[GitHub] [incubator-nuttx] tito97sp commented on a diff in pull request #7400: board/stm32h7: Fix CONFIG_LIB_BOARDCTL build cap in stm32_boot.c

Sun, 23 Oct 2022 14:17:21 -0700 


tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648


##########
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##########
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
 #ifdef CONFIG_BOARD_LATE_INITIALIZE
 void board_late_initialize(void)
 {
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)

Review Comment:
   Regarding the implementation of the `board_late_initialize()` I have found 
that there exist several implementations of the same function as resumed in the 
next diagram:
   
   ![Untitled Diagram 
drawio](https://user-images.githubusercontent.com/25639961/197418606-c64d0124-e10b-42b7-a549-ac3cc14c26f9.png)
   
   Where the different color paths are taken depending on the build caps used.
   
   Maybe an effort should be done here in homogenizing this as it is really 
difficult to understand the proper way to initialize the board.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to