tito97sp commented on code in PR #7400:
URL: https://github.com/apache/incubator-nuttx/pull/7400#discussion_r1002773648
##########
boards/arm/stm32h7/nucleo-h743zi/src/stm32_boot.c:
##########
@@ -86,7 +86,7 @@ void stm32_boardinitialize(void)
#ifdef CONFIG_BOARD_LATE_INITIALIZE
void board_late_initialize(void)
{
-#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_BOARDCTL)
+#if defined(CONFIG_NSH_LIBRARY) && !defined(CONFIG_LIB_BOARDCTL)
Review Comment:
Regarding the implementation of the `board_late_initialize()` I have found
that there exist several implementations of the same function as resumed in the
next diagram:
Where the different color paths are taken depending on the build caps used
of the same color. (Black color indicates that no build caps check are done in
some implementations)
Maybe an effort should be done here in homogenizing this as it is really
difficult to understand the proper way to initialize the board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
