masayuki2009 commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1015974954
##########
arch/arm/src/stm32h7/stm32_i2c.c:
##########
@@ -2805,7 +2805,6 @@ int stm32_i2cbus_uninitialize(struct i2c_master_s *dev)
if (--priv->refs)
{
nxmutex_unlock(&priv->lock);
- kmm_free(dev);
return OK;
Review Comment:
@xiaoxiang781216
Does this change relate to `Don't check nxsem_init and nxmutex_init ` ?
##########
arch/arm/src/stm32/stm32_i2c_v2.c:
##########
@@ -2804,7 +2804,6 @@ int stm32_i2cbus_uninitialize(struct i2c_master_s *dev)
if (--priv->refs)
{
nxmutex_unlock(&priv->lock);
- kmm_free(dev);
return OK;
Review Comment:
@xiaoxiang781216
Does this change relate to `Don't check nxsem_init and nxmutex_init ` ?
##########
arch/arm/src/cxd56xx/cxd56_spi.c:
##########
@@ -77,7 +77,6 @@ struct cxd56_spidev_s
uint8_t port; /* Port number */
int initialized; /* Initialized flag */
#ifdef CONFIG_CXD56_DMAC
- bool dmaenable; /* Use DMA or not */
Review Comment:
@xiaoxiang781216
Does this change relate to `Initialize global mutext/sem by
NXMUTEX_INITIALIZER and SEM_INITIALIZER` ?
##########
arch/arm/src/stm32l4/stm32l4_1wire.c:
##########
@@ -1247,7 +1247,6 @@ int stm32l4_1wireuninitialize(struct onewire_dev_s *dev)
if (--priv->refs)
{
nxmutex_unlock(&priv->lock);
- kmm_free(priv);
return OK;
Review Comment:
@xiaoxiang781216
Does this change relate to `Don't check nxsem_init and nxmutex_init ` ?
##########
arch/arm/src/cxd56xx/cxd56_spi.c:
##########
@@ -1328,25 +1336,13 @@ void cxd56_spi_dmaconfig(int port, int chtype,
DMA_HANDLE handle,
priv->txdmach = handle;
memcpy(&priv->txconfig, conf, sizeof(dma_config_t));
-
- if (!priv->dmaenable)
- {
- nxsem_init(&priv->dmasem, 0, 0);
- priv->dmaenable = true;
- }
}
Review Comment:
@xiaoxiang781216
Does this change relate to `Initialize global mutext/sem by
NXMUTEX_INITIALIZER and SEM_INITIALIZER` ?
##########
arch/arm/src/cxd56xx/cxd56_spi.c:
##########
@@ -1328,25 +1336,13 @@ void cxd56_spi_dmaconfig(int port, int chtype,
DMA_HANDLE handle,
priv->txdmach = handle;
memcpy(&priv->txconfig, conf, sizeof(dma_config_t));
-
- if (!priv->dmaenable)
- {
- nxsem_init(&priv->dmasem, 0, 0);
- priv->dmaenable = true;
- }
}
else if ((chtype == CXD56_SPI_DMAC_CHTYPE_RX) && (!priv->rxdmach))
{
/* RX DMA setting */
priv->rxdmach = handle;
memcpy(&priv->rxconfig, conf, sizeof(dma_config_t));
-
- if (!priv->dmaenable)
- {
- nxsem_init(&priv->dmasem, 0, 0);
- priv->dmaenable = true;
- }
}
Review Comment:
@xiaoxiang781216
Does this change relate to `Initialize global mutext/sem by
NXMUTEX_INITIALIZER and SEM_INITIALIZER` ?
##########
arch/arm/src/cxd56xx/cxd56_spi.c:
##########
@@ -863,15 +878,13 @@ static void spi_exchange(struct spi_dev_s *dev, const
void *txbuffer,
void *rxbuffer, size_t nwords)
{
#ifdef CONFIG_CXD56_DMAC
- struct cxd56_spidev_s *priv = (struct cxd56_spidev_s *)dev;
-
#ifdef CONFIG_CXD56_SPI_DMATHRESHOLD
size_t dmath = CONFIG_CXD56_SPI_DMATHRESHOLD;
#else
size_t dmath = 0;
#endif
- if (priv->dmaenable && dmath < nwords)
Review Comment:
@xiaoxiang781216
Does this change relate to `Initialize global mutext/sem by
NXMUTEX_INITIALIZER and SEM_INITIALIZER` ?
##########
arch/arm/src/stm32f0l0g0/stm32_i2c.c:
##########
@@ -2803,7 +2803,6 @@ int stm32_i2cbus_uninitialize(struct i2c_master_s *dev)
if (--priv->refs)
{
nxmutex_unlock(&priv->lock);
- kmm_free(dev);
Review Comment:
@xiaoxiang781216
Does this change relate to `Don't check nxsem_init and nxmutex_init ` ?
##########
arch/arm/src/cxd56xx/cxd56_spi.c:
##########
@@ -1204,7 +1217,6 @@ struct spi_dev_s *cxd56_spibus_initialize(int port)
/* DMA settings */
#ifdef CONFIG_CXD56_DMAC
- priv->dmaenable = false;
Review Comment:
@xiaoxiang781216
Does this change relate to `Initialize global mutext/sem by
NXMUTEX_INITIALIZER and SEM_INITIALIZER` ?
##########
arch/arm/src/stm32f7/stm32_i2c.c:
##########
@@ -2842,7 +2842,6 @@ int stm32_i2cbus_uninitialize(struct i2c_master_s *dev)
if (--priv->refs)
{
nxmutex_unlock(&priv->lock);
- kmm_free(dev);
return OK;
Review Comment:
@xiaoxiang781216
Does this change relate to `Don't check nxsem_init and nxmutex_init ` ?
##########
arch/arm/src/stm32l4/stm32l4_i2c.c:
##########
@@ -3007,7 +3007,6 @@ int stm32l4_i2cbus_uninitialize(struct i2c_master_s *dev)
if (--priv->refs)
{
nxmutex_unlock(&priv->lock);
- kmm_free(dev);
return OK;
Review Comment:
@xiaoxiang781216
Does this change relate to `Don't check nxsem_init and nxmutex_init ` ?
##########
arch/risc-v/src/bl602/bl602_spi.c:
##########
@@ -1671,7 +1671,7 @@ struct spi_dev_s *bl602_spibus_initialize(int port)
nxmutex_lock(&priv->lock);
if (priv->refs != 0)
{
- priv->refs--;
+ priv->refs++;
nxmutex_unlock(&priv->lock);
Review Comment:
@xiaoxiang781216
Does this change relate to `Don't check nxsem_init and nxmutex_init ` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
