[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

[GitBox]

xiaoxiang781216 commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1016100185


##########
arch/arm/src/cxd56xx/cxd56_spi.c:
##########
@@ -863,15 +878,13 @@ static void spi_exchange(struct spi_dev_s *dev, const 
void *txbuffer,
                          void *rxbuffer, size_t nwords)
 {
 #ifdef CONFIG_CXD56_DMAC
-  struct cxd56_spidev_s *priv = (struct cxd56_spidev_s *)dev;
-
 #ifdef CONFIG_CXD56_SPI_DMATHRESHOLD
   size_t dmath = CONFIG_CXD56_SPI_DMATHRESHOLD;
 #else
   size_t dmath = 0;
 #endif
 
-  if (priv->dmaenable && dmath < nwords)

Review Comment:
   Yes, dmaenable was used to inidicate whether dmasem finish the 
initialization, mutex/sem is initialized statically far before the spi driver, 
so we don't need dmaenable anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org