[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7472: Initialize global mutext/sem by NXMUTEX_INITIALIZER and SEM_INITIALIZER

[GitBox]

pkarashchenko commented on code in PR #7472:
URL: https://github.com/apache/incubator-nuttx/pull/7472#discussion_r1017206738


##########
arch/arm/src/stm32f0l0g0/stm32_dma_v1.c:
##########
@@ -100,62 +100,74 @@ static struct stm32_dma_s g_dma[DMA_NCHANNELS] =
   {
     .chan     = 0,
     .irq      = STM32_IRQ_DMA1CH1,
+    .sem      = SEM_INITIALIZER(0),

Review Comment:
   ```suggestion
       .sem      = SEM_INITIALIZER(1),
   ```
   here and in other places in this file



##########
arch/renesas/src/rx65n/rx65n_usbhost.c:
##########
@@ -496,9 +500,9 @@ typedef struct usb_pipe_table
     uint16_t    pipe_peri;
 } usb_pipe_table_t;
 
-usb_pipe_table_t    g_usb_pipe_table [USB_MAX_PIPE_NUM + 1];
+usb_pipe_table_t    g_usb_pipe_table[USB_MAX_PIPE_NUM + 1];

Review Comment:
   ```suggestion
   usb_pipe_table_t g_usb_pipe_table[USB_MAX_PIPE_NUM + 1];
   ```



##########
arch/xtensa/src/esp32s2/esp32s2_i2s.c:
##########
@@ -396,34 +391,16 @@ static struct esp32s2_i2s_s esp32s2_i2s0_priv =
         {
           .ops = &g_i2sops
         },

Review Comment:
   ```suggestion
       {
         .ops = &g_i2sops
       },
   ```



##########
arch/arm/src/sama5/sam_twi.c:
##########
@@ -229,6 +229,14 @@ static void twi_hw_initialize(struct twi_dev_s *priv, 
uint32_t frequency);
  * Private Data
  ****************************************************************************/
 
+static const struct i2c_ops_s g_twiops =
+{
+  .transfer = twi_transfer
+#ifdef CONFIG_I2C_RESET
+  , .reset  = twi_reset

Review Comment:
   ```suggestion
     .transfer = twi_transfer,
   #ifdef CONFIG_I2C_RESET
     .reset  = twi_reset
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org