davids5 commented on code in PR #7809: URL: https://github.com/apache/nuttx/pull/7809#discussion_r1043193334
########## drivers/segger/note_sysview.c: ########## @@ -275,7 +276,12 @@ static inline int sysview_isenabled_syscall(int nr) * ****************************************************************************/ -void sched_note_start(FAR struct tcb_s *tcb) +void weak_function sched_note_start(FAR struct tcb_s *tcb) +{ + sysview_note_start(tcb); +} + +void inline sysview_note_start(FAR struct tcb_s *tcb) Review Comment: I still think it cleaner to have a KCOFIG option for the sysview module to a prefix ``` #if !defined(CONFIG_SYSTEMVIEW_PREFIX) # define sysview_prefix #else # define sysview_prefix CONFIG_SYSTEMVIEW_PREFIX // or define sysview_prefix define sysview #endif sysview_prefix_sched_note_resume(FAR struct tcb_s *tcb) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org