[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7809: Systemview make note function weak for co-existance with other note drivers

[GitBox]

pkarashchenko commented on code in PR #7809:
URL: https://github.com/apache/nuttx/pull/7809#discussion_r1043240284


##########
drivers/segger/note_sysview.c:
##########
@@ -275,7 +276,12 @@ static inline int sysview_isenabled_syscall(int nr)
  *
  ****************************************************************************/
 
-void sched_note_start(FAR struct tcb_s *tcb)
+void weak_function sched_note_start(FAR struct tcb_s *tcb)
+{
+  sysview_note_start(tcb);
+}
+
+void inline sysview_note_start(FAR struct tcb_s *tcb)

Review Comment:
   I see that you already implemented `CONFIG_SYSTEMVIEW_PREFIX` approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org