[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7809: Systemview make note function weak for co-existance with other note drivers

[GitBox]

pkarashchenko commented on code in PR #7809:
URL: https://github.com/apache/nuttx/pull/7809#discussion_r1043239298


##########
drivers/segger/note_sysview.c:
##########
@@ -275,7 +276,12 @@ static inline int sysview_isenabled_syscall(int nr)
  *
  ****************************************************************************/
 
-void sched_note_start(FAR struct tcb_s *tcb)
+void weak_function sched_note_start(FAR struct tcb_s *tcb)
+{
+  sysview_note_start(tcb);
+}
+
+void inline sysview_note_start(FAR struct tcb_s *tcb)

Review Comment:
   @PetervdPerk-NXP Yes, I understood the idea, but need to refresh in my 
memory how `inline` works in C. I experimented with it long time ago and do not 
remember correctly. I mean do we need
   ```
   void inline a(void)
   {
   }
   
   void b(void)
   {
     a();
   }
   ```
   or
   ```
   void b(void)
   {
     a();
   }
   
   void inline a(void)
   {
   }
   ```
   I mean do we need to have `a` declared before `b` use it.
   The `CONFIG_SYSTEMVIEW_PREFIX` seems to be cleaner, but most probably will 
require some `##` supplementary macros to be added to generate the names. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org