xiaoxiang781216 commented on code in PR #8449: URL: https://github.com/apache/nuttx/pull/8449#discussion_r1098274504
########## tools/Win.mk: ########## @@ -571,33 +571,38 @@ pass2dep: context tools\mkdeps$(HOSTEXEEXT) # location: https://bitbucket.org/nuttx/tools/downloads/. See # misc\tools\README.txt for additional information. +KCONFIG_ENV = set APPSDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set EXTERNALDIR=$(EXTERNALDIR)& \ + set APPSBINDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ Review Comment: add sapce before all & ########## tools/Win.mk: ########## @@ -571,33 +571,38 @@ pass2dep: context tools\mkdeps$(HOSTEXEEXT) # location: https://bitbucket.org/nuttx/tools/downloads/. See # misc\tools\README.txt for additional information. +KCONFIG_ENV = set APPSDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set EXTERNALDIR=$(EXTERNALDIR)& \ + set APPSBINDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set BINDIR=$(patsubst "%",%,${TOPDIR})& + config: $(Q) $(MAKE) clean_context $(Q) $(MAKE) apps_preconfig - $(Q) set APPSDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& set EXTERNALDIR=$(EXTERNALDIR)& kconfig-conf Kconfig + $(Q) $() kconfig-conf Kconfig Review Comment: ```suggestion $(Q) $(KCONFIG_ENV) kconfig-conf Kconfig ``` ########## tools/Win.mk: ########## @@ -571,33 +571,38 @@ pass2dep: context tools\mkdeps$(HOSTEXEEXT) # location: https://bitbucket.org/nuttx/tools/downloads/. See # misc\tools\README.txt for additional information. +KCONFIG_ENV = set APPSDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set EXTERNALDIR=$(EXTERNALDIR)& \ + set APPSBINDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set BINDIR=$(patsubst "%",%,${TOPDIR})& Review Comment: ```suggestion set BINDIR=$(patsubst "%",%,${TOPDIR}) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
