anchao commented on code in PR #8449: URL: https://github.com/apache/nuttx/pull/8449#discussion_r1098349093
########## tools/Win.mk: ########## @@ -571,33 +571,38 @@ pass2dep: context tools\mkdeps$(HOSTEXEEXT) # location: https://bitbucket.org/nuttx/tools/downloads/. See # misc\tools\README.txt for additional information. +KCONFIG_ENV = set APPSDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set EXTERNALDIR=$(EXTERNALDIR)& \ + set APPSBINDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set BINDIR=$(patsubst "%",%,${TOPDIR})& Review Comment: Last symbol is also required ########## tools/Win.mk: ########## @@ -571,33 +571,38 @@ pass2dep: context tools\mkdeps$(HOSTEXEEXT) # location: https://bitbucket.org/nuttx/tools/downloads/. See # misc\tools\README.txt for additional information. +KCONFIG_ENV = set APPSDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ + set EXTERNALDIR=$(EXTERNALDIR)& \ + set APPSBINDIR=$(patsubst "%",%,${CONFIG_APPS_DIR})& \ Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
