xiaoxiang781216 commented on code in PR #8449: URL: https://github.com/apache/nuttx/pull/8449#discussion_r1098951035
########## Kconfig: ########## @@ -2124,7 +2132,7 @@ source "openamp/Kconfig" endmenu menu "Application Configuration" -source "$APPSDIR/Kconfig" +source "$APPSBINDIR/Kconfig" Review Comment: @davids5 since apps/Kconfig is generated dynamically. Changing $APPSDIR to $APPSBINDIR could move the generated Kconfig to the different directory, so it's the required step to support the out of tree build. BTW, since APPSBINDIR is same as APPSDIR by default. The behaviour keeps the same as before, but APPSBINDIR will set to a different path in cmake build system for out of tree build. So, you can see that all generated Kconfig change to BINDIR for nuttx repo or APPSBINDIR for apps repo, but all manual written Kconfig doesn't change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
