anchao commented on code in PR #8619:
URL: https://github.com/apache/nuttx/pull/8619#discussion_r1115162009
##########
drivers/note/note_driver.c:
##########
@@ -259,7 +261,17 @@ static void note_common(FAR struct tcb_s *tcb,
#else
/* Save the LS 32-bits of the system timer in little endian order */
- sched_note_flatten(note->nc_systime, &systime, sizeof(systime));
+#ifdef CONFIG_SCHED_INSTRUMENTATION_PERFCOUNT
Review Comment:
indent
##########
Kconfig:
##########
@@ -2005,6 +2005,90 @@ config FRAME_POINTER
endmenu # Debug Options
+menuconfig TRACE
+ bool "Enable tracepoints"
+ default n
+ depends on SCHED_INSTRUMENTATION_DUMP && DRIVERS_NOTE
+ ---help---
+ If this option is enabled, tracepoints at critical code in
+ the kernel will be enabled.
+
+if TRACE
+
+config TRACE_BINFMT
+ bool "Enable tracepoints in binfmt"
+ default n
+
+config TRACE_BOARDS
+ bool "Enable tracepoints in boards"
+ default n
+
+config TRACE_CRYPTO
+ bool "Enable tracepoints in crypto"
+ default n
+
+config TRACE_DRIVERS
+ bool "Enable tracepoints in drivers"
+ default n
+
+config TRACE_INPUT
+ bool "Enable tracepoints in input"
Review Comment:
Why need to classify traces as modules? I think inside the module they can
be configured dynamically
##########
binfmt/binfmt_initialize.c:
##########
@@ -28,6 +28,7 @@
#include <nuttx/binfmt/elf.h>
#include <nuttx/binfmt/nxflat.h>
#include <nuttx/lib/builtin.h>
+#include <nuttx/trace.h>
Review Comment:
All `#include <nuttx/trace.h> `can be unified in the header files of
subdirectories: binfmt.h:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
