Gary-Hobson commented on code in PR #8619:
URL: https://github.com/apache/nuttx/pull/8619#discussion_r1120086656
##########
binfmt/binfmt_initialize.c:
##########
@@ -28,6 +28,7 @@
#include <nuttx/binfmt/elf.h>
#include <nuttx/binfmt/nxflat.h>
#include <nuttx/lib/builtin.h>
+#include <nuttx/trace.h>
Review Comment:
I didn't find a suitable header file to put it in,
and it's not a good idea to introduce too many dependencies in the header
file
##########
drivers/note/note_driver.c:
##########
@@ -223,12 +223,14 @@ static void note_common(FAR struct tcb_s *tcb,
FAR struct note_common_s *note,
uint8_t length, uint8_t type)
{
-#ifdef CONFIG_SCHED_INSTRUMENTATION_HIRES
struct timespec ts;
-
+#ifdef CONFIG_SCHED_INSTRUMENTATION_HIRES
clock_systime_timespec(&ts);
#else
clock_t systime = clock_systime_ticks();
+# ifdef CONFIG_SCHED_INSTRUMENTATION_PERFCOUNT
+ uint32_t count = up_perf_gettime();
Review Comment:
done
##########
Kconfig:
##########
@@ -2005,6 +2005,90 @@ config FRAME_POINTER
endmenu # Debug Options
+menuconfig TRACE
+ bool "Enable tracepoints"
+ default n
+ depends on SCHED_INSTRUMENTATION_DUMP && DRIVERS_NOTE
+ ---help---
+ If this option is enabled, tracepoints at critical code in
+ the kernel will be enabled.
+
+if TRACE
+
+config TRACE_BINFMT
+ bool "Enable tracepoints in binfmt"
+ default n
+
+config TRACE_BOARDS
+ bool "Enable tracepoints in boards"
+ default n
+
+config TRACE_CRYPTO
+ bool "Enable tracepoints in crypto"
+ default n
+
+config TRACE_DRIVERS
+ bool "Enable tracepoints in drivers"
+ default n
+
+config TRACE_INPUT
+ bool "Enable tracepoints in input"
Review Comment:
Done
I added tags to sched_note_string/printf to support runtime filtering, but
it is still configurable at compile time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
