xiaoxiang781216 commented on code in PR #8665:
URL: https://github.com/apache/nuttx/pull/8665#discussion_r1119225224


##########
arch/arm64/src/common/arm64_gicv3.c:
##########
@@ -577,8 +613,8 @@ static void arm64_gic_init(void)
   int       err;
 
   cpu               = this_cpu();
-  gic_rdists[cpu]   = CONFIG_GICR_BASE +
-                     MPIDR_TO_CORE(GET_MPIDR()) * 0x20000;
+
+  gic_rdists[cpu]   = g_arm64_cpu_info[cpu].gicr_base;

Review Comment:
   can we add arm64_gic_get_gicr_base or change 0x20000 to a macro defined in 
chip.h?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to