acassis commented on code in PR #9487: URL: https://github.com/apache/nuttx/pull/9487#discussion_r1224817819
########## include/dsp.h: ########## @@ -447,6 +447,14 @@ struct pmsm_model_f32_s float iq_int; /* Iq integral part */ }; +/* Average filter */ + +struct avg_filter_data_s Review Comment: @pkarashchenko I don't know... I think the other way with only the init() and avg_filter() was simpler. Now we are forcing user to call three functions and we lost the mathematical meaning (the reference to prev_avg variable). Maybe it's impossible to please two gods! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
