acassis commented on code in PR #9487: URL: https://github.com/apache/nuttx/pull/9487#discussion_r1225489476
########## include/dsp.h: ########## @@ -447,6 +447,14 @@ struct pmsm_model_f32_s float iq_int; /* Iq integral part */ }; +/* Average filter */ + +struct avg_filter_data_s Review Comment: Thank you for your suggestion @mu578! I also like to follow some standard, but AFAIK there is not good C standard dsp signal APIs and our current libdsp is not following any existing standard, correct @raiden00pl ? Anyway the NuttX libdsp is very simple and intuitive to use. scopy.signal fall shorter here, see an example about moving average: https://stackoverflow.com/questions/13728392/moving-average-or-running-mean/43200476#43200476 Should we follow CMSIS-DSP? https://schaumont.dyn.wpi.edu/ece4703b21/lecture7.html I don't think it is a good idea, because vendors that are ARM's competitor will not like it. So, I suggest KISS methodology like libdsp seems to be following. If in the future POSIX defines some standard to DSP library we could adopt it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
