xiaoxiang781216 commented on PR #10077: URL: https://github.com/apache/nuttx/pull/10077#issuecomment-1681011655
> Nice work @Otpvondoiats ! But I think the IOCTLs and data rate control should be in the main driver instead of only existing only in the _uorb. > > So the user application even when not using uorb will be able to use IOCTLs to control many features, like it is done in some char driver sensors already. @acassis as I mention before, the old sensor driver doesn't follow nuttx driver model, e.g.: 1. Separate upperhalf and lowerhalf 2. Define the common IOCTL and struct So, we don't plan to do any enhancement to the old drivers which demonstrate the bad practice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
