raiden00pl commented on code in PR #10282: URL: https://github.com/apache/nuttx/pull/10282#discussion_r1298389827
########## include/nuttx/math/cordic.h: ########## @@ -119,6 +117,8 @@ struct cordic_calc_s /* CORDIC request configuration */ uint8_t func; /* CORDIC function */ + int8_t input_scale; Review Comment: Please add comments for added parameters as it is for `func` and `res2_incl` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
