xiaoxiang781216 commented on PR #10282: URL: https://github.com/apache/nuttx/pull/10282#issuecomment-1684050578
> CONFIG_MATH_CORDIC_USE_Q31 is not redundant. It's CORDIC implementation feature and your lower-half implementation should select this option if needed. There are CORDIC peripherals that support q1.15 (int16_t) and this option allows you to implement other numerical types. @raiden00pl but if defconfig doesn't enable CONFIG_MATH_CORDIC_USE_Q31, the compiler will complain that cordic_num_t at https://github.com/apache/nuttx/pull/10282/files#diff-2935a1615b202c6a7277770f43b933c03916d03bfc303ec732b12dcadbf9737fR126 is undefined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
