behappy1234 commented on PR #10282: URL: https://github.com/apache/nuttx/pull/10282#issuecomment-1685518888
> CONFIG_MATH_CORDIC_USE_Q31 is not redundant. It's CORDIC implementation feature and your lower-half implementation should select this option if needed. There are CORDIC peripherals that support q1.15 (int16_t) and this option allows you to implement other numerical types. Yes, the numerical type for q1.15 is as a default here. I do this, because if I open for MATH_FFT, then math.c is compiled, so cordic.h is included and CONFIG_MATH_CORDIC_USE_Q31 is needed for cordic_num_t to be configed even in this case I don't need to care about cordic. So, CONFIG_MATH_CORDIC_USE_Q31 is "redundant" here, or a default cordic_num_t definition is need. And I remove it as a default one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
